Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use path.posix.relative #801

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: do not use path.posix.relative #801

merged 2 commits into from
Dec 5, 2024

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 5, 2024

Actually fixes #774

I made a mistake while rebasing the previous PR and the problem was still not fixed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

@stylexjs/[email protected] size:compare
./size-compare.js /tmp/tmp.JEvIMQpapT /tmp/tmp.WBhPjC3JAR

Results Base Patch Ratio
stylex/lib/stylex.js
· compressed 729 729 1.00
· minified 2,541 2,541 1.00
stylex/lib/StyleXSheet.js
· compressed 1,266 1,266 1.00
· minified 3,776 3,776 1.00
rollup-example/.build/bundle.js
· compressed 562,983 562,983 1.00
· minified 10,185,368 10,185,368 1.00
rollup-example/.build/stylex.css
· compressed 99,229 99,229 1.00
· minified 745,845 745,845 1.00

@nmn nmn merged commit c882412 into main Dec 5, 2024
8 checks passed
@nmn nmn deleted the fix/windows-import-path-3 branch December 5, 2024 23:14
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 22, 2024
* fix: do not use path.posix.relative
* prettier
aminaopio pushed a commit to aminaopio/stylex that referenced this pull request Dec 22, 2024
* fix: do not use path.posix.relative
* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getting errors with using the stylex CLI in next 15 App dir.
2 participants